Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema Card consistency across all pages #299

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Schema Card consistency across all pages #299

merged 4 commits into from
Sep 25, 2023

Conversation

bhavanakarwade
Copy link
Contributor

What

  • Make Schema card consistent across all interfaces.
  • Added responsiveness to the Schema cards.
  • Make cred-def and schema card consistent on view schema page.

@bhavanakarwade
fix: Made schema Card consistence across all interfaces
78ce7f6 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade bhavanakarwade added the bug Something isn't working label Sep 22, 2023
@bhavanakarwade bhavanakarwade self-assigned this Sep 22, 2023
@bhavanakarwade
make attributes on next line and handled responsiveness
752d3b6 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
resolved conflicts
274cd5c 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
resolved conflicts
b99f60e 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

nishad-ayanworks
nishad-ayanworks approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nishad-ayanworks nishad-ayanworks merged commit 5f2d4d0 into develop Sep 25, 2023
4 checks passed
@nishad-ayanworks nishad-ayanworks deleted the 103-schema-card-consistency-across-all-pages branch September 25, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishad-ayanworks nishad-ayanworks nishad-ayanworks approved these changes

@tipusinghaw tipusinghaw Awaiting requested review from tipusinghaw

Assignees

@bhavanakarwade bhavanakarwade

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhavanakarwade @nishad-ayanworks