Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oob email issuance #485

Merged
merged 17 commits into from
Dec 15, 2023
Merged

feat: oob email issuance #485

merged 17 commits into from
Dec 15, 2023

Conversation

16-karan
Copy link
Contributor

WHAT

  • OOB Multiple Email Issuance
  • Changed flow and folder structure
  • Created the common page for all types of issuance
  • Implemented OOB email issuance
  • Handled popup for confirmation
  • Handled popup for reset
  • Handled responsiveness
  • Handled dark and light mode
  • Made required changes to make code clean and readable
  • Implemented user-friendly ui
  • Implemented error handling and validation
  • Commented the code for future requirements with proper comments

WHY

  • To provide ease of doing issuance for fewer records using email
  • To provide an alternate way for bulk issuance when records are less

HOW

  • Created the user-friendly UI
  • Implemented the back-end API to achieve functionality

Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
…-oob-email-issuance

Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
…-oob-email-issuance

Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
}

interface ICredentials {
credentialDefinitionId: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove these interfaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of our commitment to best practices, we've opted to create distinct interfaces for each feature or folder, consolidating initial interfaces from individual files into a common interface file

…-oob-email-issuance

Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
Signed-off-by: karan <karan.tompe@ayanworks.com>
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

18 New issues
0 Security Hotspots
No data about Coverage
2.7% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nishad-ayanworks nishad-ayanworks merged commit 6090f80 into develop Dec 15, 2023
5 checks passed
@16-karan 16-karan deleted the feat-oob-email-issuance branch February 5, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants