Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: API Change, Bug Fixes #15

Merged
merged 3 commits into from
Dec 20, 2018
Merged

FEATURE: API Change, Bug Fixes #15

merged 3 commits into from
Dec 20, 2018

Conversation

roblafeve
Copy link
Contributor

@roblafeve roblafeve commented Dec 20, 2018

Overview

This updates the API and fixes a few issues mentioned below. README has been updated accordingly.

  • CHANGE: Separate element and component props to eliminate overloads
  • FIX: string/number child node should be wrapped in BoxlChild
  • FIX: Default props should maintain precedence over parent child* props
  • FEATURE: Add tests for element and component

closes #13

Review Checklist

  • Merge destination is correct
  • Tests cases have been added where appropriate (Jest, Loki, Cypress)
  • Code is correct as understood and conforms to quality standards

Testing Instructions

  1. Run test suite

- CHANGE: Separate `element` and `component` props to eliminate overloads
- FIX: String/number child node should be wrapped in BoxlChild
- FIX: Default props should maintain precedence over parent `child*` props
@codecov-io
Copy link

codecov-io commented Dec 20, 2018

Codecov Report

Merging #15 into develop will increase coverage by 1.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #15      +/-   ##
=========================================
+ Coverage    98.87%   100%   +1.12%     
=========================================
  Files           10      9       -1     
  Lines          178    180       +2     
  Branches        58     58              
=========================================
+ Hits           176    180       +4     
+ Partials         2      0       -2
Impacted Files Coverage Δ
src/lib/boxl/index.tsx 100% <ø> (ø) ⬆️
src/lib/BoxlComponent/index.tsx 100% <100%> (+2%) ⬆️
src/index.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65fe980...e418900. Read the comment docs.

@roblafeve roblafeve merged commit f5e8c1b into develop Dec 20, 2018
@roblafeve roblafeve deleted the feature/updates-fixes branch December 20, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text node doesn't get wrapped with BoxChild when using spacing
3 participants