Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing docker action to respect DOCKER_LATEST_BRANCH #12

Merged
merged 4 commits into from
Jul 21, 2021
Merged

Fixing docker action to respect DOCKER_LATEST_BRANCH #12

merged 4 commits into from
Jul 21, 2021

Conversation

scallister
Copy link
Contributor

Created in response to:
https://github.com/cresta/magehelper/pull/11/files/547ba72bcc3e3f77b59e2e35dc4d45caa8cc8b89#r664730664

@cep21 I think this will respect DOCKER_LATEST_BRANCH better.

@scallister scallister requested a review from cep21 July 6, 2021 18:31
@scallister scallister self-assigned this Jul 6, 2021
@scallister scallister mentioned this pull request Jul 6, 2021
Merged
@scallister
Copy link
Contributor Author

scallister commented Jul 9, 2021 •
edited
Loading

@cep21 I think this PR slipped through the cracks. Did you still want this?

It's failing on a naked return. Here is a PR to fix that:
#14

@scallister scallister mentioned this pull request Jul 9, 2021
Merged
cep21
cep21 suggested changes Jul 10, 2021
View reviewed changes
docker/docker.go Outdated Show resolved Hide resolved
@scallister scallister requested a review from cep21 July 21, 2021 00:58
cep21
cep21 approved these changes Jul 21, 2021
View reviewed changes
docker/docker.go Outdated Show resolved Hide resolved
@scallister scallister merged commit 57968ae into master Jul 21, 2021
@scallister scallister deleted the scallister/fix_docker_latest_branch_default branch July 21, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cep21 cep21 cep21 approved these changes

Assignees

@scallister scallister

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scallister @cep21