Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing decrement of j in snapshots example. #1006

Merged
merged 4 commits into from
May 20, 2024

Conversation

isan-Ethen
Copy link

The example on the snapshots page of the Creusot User Guide is an insertion sort, but the decrement of j inside the while loop is missing.

@xldenis
Copy link
Collaborator

xldenis commented May 20, 2024

Thanks! if you don't mind I'm going to add a proof for this as well.

@isan-Ethen
Copy link
Author

Thank you for your response! Of course I don't mind.

@xldenis
Copy link
Collaborator

xldenis commented May 20, 2024

I've added insertion_sort.rs with a proof, and adjusted the documentation to highlight the usage of snapshot! without getting lost in the details of the proof.

@isan-Ethen
Copy link
Author

Sorry, is there any problem with my pull request?

@xldenis
Copy link
Collaborator

xldenis commented May 20, 2024

Nope! only with my proof.

@isan-Ethen
Copy link
Author

Ah, I see. I was worried if I had made any mistakes.

@xldenis
Copy link
Collaborator

xldenis commented May 20, 2024

there we go, this should work. It turns out we merged #1005 just before I pushed my commit which bumped the version of Alt-Ergo causing the proof to be considered out of date.

@xldenis xldenis merged commit 7feb3de into creusot-rs:master May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants