Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📛 Rename Transition to Procedure [#65] #66

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

crexista
Copy link
Owner

UPDATE

  • Scenario's protocol is named Transition, but scenario does not transition, but handle transtion.
  • So, scenario close to procedure rather than transition
  • Transition keyword will be used other class

@codecov-io
Copy link

codecov-io commented Jun 19, 2017

Codecov Report

Merging #66 into versions/0.3.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           versions/0.3.0      #66   +/-   ##
===============================================
  Coverage           91.45%   91.45%           
===============================================
  Files                   7        7           
  Lines                 117      117           
===============================================
  Hits                  107      107           
  Misses                 10       10
Impacted Files Coverage Δ
KabuKit/Classes/core/Swift/SceneSequence.swift 100% <100%> (ø) ⬆️
KabuKit/Classes/core/Swift/Scenario.swift 93.75% <100%> (ø) ⬆️
KabuKit/Classes/core/Swift/Screen.swift 60% <100%> (ø) ⬆️
KabuKit/Classes/core/Swift/SceneOperation.swift 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dcecf7...5a4412e. Read the comment docs.

@crexista crexista changed the title 📛 Rename Transition to Procedure [#64] 📛 Rename Transition to Procedure [#65] Jun 19, 2017
@crexista crexista added this to the ver0.3.0 milestone Jun 19, 2017
** UPDATE **
 - Scenario's protocol is named `Transition`, but scenario does not transition, but handle transtion.
 - So, scenario close to `procedure` rather than `transition`
 - `Transition` keyword will be used other class
@crexista crexista merged commit 6548b56 into versions/0.3.0 Jun 20, 2017
@crexista crexista deleted the fix/rename_transition branch June 20, 2017 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants