Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Scene's ReturnValue associetedType #85

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

crexista
Copy link
Owner

Detail
This commit change Scene's ReturnValue gained through rewind method was Optional to Non Optional.
Because, it is inconvenient because it is necessary to check nil when receiving RetuneValue.

Breaking Change
initialize TransitionRequest have to change this.

  • before
let request = HogeRequest() { ret in // result is optional
   guard let result = result else { return }
   // process using result
}
  • after
let request = HogeRequest() { ret in // result is non-optional
   // process using result
}

**Detail**
This commit change `Scene`'s ReturnValue gained through `rewind method` was Optional to Non Optional.
Because, it is inconvenient because it is necessary to check nil when receiving RetuneValue.

**Breaking Change**
initialize `TransitionRequest` have to change this.

- before

```swift
let request = HogeRequest() { ret in // result is optional
   guard let result = result else { return }
   // process using result
}
```
- after

```swift
let request = HogeRequest() { ret in // result is non-optional
   // process using result
}
```
@crexista crexista force-pushed the refactor/change_retunvalue_type branch from 0e88230 to 44d0a9f Compare September 28, 2017 11:35
@crexista crexista merged commit 384c0d4 into versions/0.4.0 Oct 3, 2017
@crexista crexista deleted the refactor/change_retunvalue_type branch October 22, 2017 13:08
@crexista crexista restored the refactor/change_retunvalue_type branch January 26, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant