Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User system refacto #422

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

User system refacto #422

wants to merge 3 commits into from

Conversation

mRoca
Copy link
Contributor

@mRoca mRoca commented Nov 4, 2020

No description provided.

@mRoca mRoca force-pushed the user-system-refacto branch 4 times, most recently from 7eb7206 to 9023323 Compare November 7, 2020 19:54
@mRoca mRoca changed the title WIP: User system refacto User system refacto Nov 7, 2020
@mRoca
Copy link
Contributor Author

mRoca commented Nov 7, 2020

@vincentchalamon je viens de terminer la partie des templates / email & tests, j'ai l'impression que tout devrait être bon, t'as fait un super taf ! T'aurais le temps de te replonger dedans histoire de voir si j'ai pas oublié un truc ?

@vincentchalamon
Copy link
Contributor

@mRoca Ça me semble bien pour cette PR, sauf la CI qui gueule (les tests à corriger je pense).

Il faudrait également mettre à jour le fichier .github/workflows/ci.yml pour corriger une dépréciation (qui est en fait une faille de sécurité).

@mRoca
Copy link
Contributor Author

mRoca commented Nov 9, 2020

J'ai vu pour les tests: c'est à cause de mes dernières modifs pour les emails. Je fix tout ça ce soir

@mRoca mRoca force-pushed the user-system-refacto branch 4 times, most recently from 781791d to c96c81f Compare November 13, 2020 11:45
@mRoca
Copy link
Contributor Author

mRoca commented Nov 13, 2020

@vincentchalamon t'en penses quoi ?

Copy link
Contributor

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pense à mettre à jour le fichier .github/workflows/ci.yaml pour corriger la faille de sécurité (cf. précédent commentaire)

Sinon c'est niquel ! Beau boulot !

tests/Behat/MailsContext.php Outdated Show resolved Hide resolved
vincentchalamon and others added 2 commits November 13, 2020 13:48
* Prepare Behat scenarios for User system refacto (#339)

* Refacto User login

* Add reset password

* Add Organization promote/revoke User

* Add ROLE_SUPER_ADMIN

* Add User impersonification for super-admin only

* Remove useless ROLE_VOLUNTEER

* wip

* Fix PHP-CS

Co-authored-by: Michel Roca <mroca.dh@gmail.com>
@mRoca
Copy link
Contributor Author

mRoca commented Nov 30, 2020

TODO before merging:

  • Définir le premier utilisateur inscrit comme SUPER_ADMIN
  • Ajouter la doc d'installation

@mRoca mRoca force-pushed the user-system-refacto branch 3 times, most recently from 943bf93 to 4ace493 Compare December 21, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants