Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

webhook_max_payload_size #1

Closed
dkmur opened this issue Sep 23, 2020 · 1 comment · Fixed by #2
Closed

webhook_max_payload_size #1

dkmur opened this issue Sep 23, 2020 · 1 comment · Fixed by #2

Comments

@dkmur
Copy link

dkmur commented Sep 23, 2020

plugin does not seem to respect parameter webhook_max_payload_size, set to 500 in my case

[09-23 14:13:18.91] [           system] [   poraclePvpHelper:491 ] [S] Successfully sent payload to webhook. Stats: 1274
[09-23 14:13:22.37] [           system] [      webhookworker:125 ] [S] Successfully sent payload to webhook [pl 1/3]. Stats: {"raid": 180, "weather": 35, "pokestop": 285}
[09-23 14:13:22.41] [           system] [      webhookworker:125 ] [S] Successfully sent payload to webhook [pl 2/3]. Stats: {"pokestop": 500}
[09-23 14:13:22.45] [           system] [      webhookworker:125 ] [S] Successfully sent payload to webhook [pl 3/3]. Stats: {"pokestop": 31}
@crhbetz
Copy link
Owner

crhbetz commented Sep 30, 2020

As discussed, I acknowledge this is unexpected behaviour. However with how the webhookworker is currently implemented, I'd have to copy more code from it over to my plugin to make webhook_max_payload_size work. Which is a mess to keep up-to-date in case of changes.

For now, in case this causes issues for the webhook receiver, I'd suggest running a shorter interval setting as a workaround.

crhbetz added a commit that referenced this issue Oct 7, 2020
@crhbetz crhbetz mentioned this issue Oct 7, 2020
@crhbetz crhbetz closed this as completed in #2 Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants