Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.27] highperfhooks: apply cgroup setting to crun cgroup #7443

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

haircommander
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix a bug where the cgroup crun configures is different than that CRI-O sets load balancing/cpu quota on

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2023
@haircommander
Copy link
Member Author

pick of #7373

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander marked this pull request as ready for review October 26, 2023 20:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2023
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #7443 (88d6cac) into release-1.27 (9a24aae) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.27    #7443   +/-   ##
=============================================
  Coverage         49.30%   49.30%           
=============================================
  Files               128      128           
  Lines             15185    15187    +2     
=============================================
+ Hits               7487     7488    +1     
- Misses             6800     6801    +1     
  Partials            898      898           

@openshift-ci openshift-ci bot merged commit 9b9c375 into cri-o:release-1.27 Oct 26, 2023
38 of 44 checks passed
@haircommander
Copy link
Member Author

/cherry-pick release-1.26

@openshift-cherrypick-robot

@haircommander: new pull request created: #7797

In response to this:

/cherry-pick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants