Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.28] OCPBUGS-41245: server/*: Fix a bug where the GID is not added to /etc/group when run_as_group is set #8564

Merged
merged 3 commits into from
Sep 18, 2024
Merged

[release-1.28] OCPBUGS-41245: server/*: Fix a bug where the GID is not added to /etc/group when run_as_group is set #8564

merged 3 commits into from
Sep 18, 2024

Conversation

kwilczynski
Copy link
Member

This is a manual cherry-pick of #8251

/assign kwilczynski

Note

This cherry-pickl brings the following Pull Request as a dependency:

Fix a bug where the GID is not added to /etc/group when run_as_group is set

saschagrunert and others added 2 commits September 7, 2024 05:17
@saschagrunert @kwilczynski
Remove Podman lookup dependency
bdc785b 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@PannagaRao @kwilczynski
server/*: Fix bug to add gid in /etc/group
c39cd00 
When securityContext of runAsGroup is added the
gid has to be added in /etc/group. This PR has
changes to add gid value under /etc/group
Test case to verify the addition of the same
is also being added

Signed-off-by: PannagaRamamanohara <pbhojara@redhat.com>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 6, 2024
@kwilczynski kwilczynski changed the title server/*: Fix a bug where the GID is not added to /etc/group when run_as_group is set [release-1.28] server/*: Fix a bug where the GID is not added to /etc/group when run_as_group is set Sep 6, 2024
@kwilczynski
Copy link
Member Author

/approve

@kwilczynski kwilczynski force-pushed the feature/backport-8251-to-release-1.28 branch from e65a57e to daa0b14 Compare September 7, 2024 15:42
@codecov Codecov
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 45.21739% with 63 lines in your changes missing coverage. Please review.

Project coverage is 48.42%. Comparing base (429d976) to head (daa0b14).
Report is 33 commits behind head on release-1.28.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.28    #8564      +/-   ##
================================================
- Coverage         48.57%   48.42%   -0.16%     
================================================
  Files               136      136              
  Lines             15992    16141     +149     
================================================
+ Hits               7768     7816      +48     
- Misses             7299     7379      +80     
- Partials            925      946      +21

@kwilczynski
Copy link
Member Author

/retest

@kwilczynski kwilczynski force-pushed the feature/backport-8251-to-release-1.28 branch from daa0b14 to dceda91 Compare September 9, 2024 08:41
@kwilczynski
Copy link
Member Author

/retest

@kwilczynski kwilczynski changed the title [release-1.28] server/*: Fix a bug where the GID is not added to /etc/group when run_as_group is set [release-1.28] OCPBUGS-41245: server/*: Fix a bug where the GID is not added to /etc/group when run_as_group is set Sep 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 9, 2024
@openshift-ci-robot
Copy link

@kwilczynski: This pull request references Jira Issue OCPBUGS-41245, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-41245 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #8251

/assign kwilczynski

[!NOTE]
This cherry-pickl brings the following Pull Request as a dependency:

Fix a bug where the GID is not added to /etc/group when run_as_group is set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski
Copy link
Member Author

Related:

@kwilczynski kwilczynski force-pushed the feature/backport-8251-to-release-1.28 branch from dceda91 to 454463c Compare September 10, 2024 06:53
@kwilczynski
Copy link
Member Author

/retest

@kwilczynski
Pin govulncheck to specific version to match Go version requirements
df0263b 
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
@kwilczynski kwilczynski force-pushed the feature/backport-8251-to-release-1.28 branch from 454463c to df0263b Compare September 16, 2024 13:32
@kwilczynski
Copy link
Member Author

@cri-o/cri-o-maintainers, please have a look. Thank you!

@haircommander
Copy link
Member

/override ci/prow/e2e-gcp
/override ci/prow/e2e-agnostic
/override ci/prow/images
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-agnostic, ci/prow/e2e-gcp, ci/prow/images

In response to this:

/override ci/prow/e2e-gcp
/override ci/prow/e2e-agnostic
/override ci/prow/images
/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 54ced80 into cri-o:release-1.28 Sep 18, 2024
40 of 42 checks passed
@openshift-ci-robot
Copy link

@kwilczynski: Jira Issue OCPBUGS-41245: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41245 has been moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of #8251

/assign kwilczynski

[!NOTE]
This cherry-pickl brings the following Pull Request as a dependency:

Fix a bug where the GID is not added to /etc/group when run_as_group is set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski kwilczynski deleted the feature/backport-8251-to-release-1.28 branch September 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@klihub klihub Awaiting requested review from klihub

Assignees

@kwilczynski kwilczynski

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kwilczynski @openshift-ci-robot @haircommander @saschagrunert @PannagaRao