Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the message in case of missing CNI files #66

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Change the message in case of missing CNI files #66

merged 1 commit into from
Dec 4, 2019

Conversation

s1061123
Copy link
Contributor

@s1061123 s1061123 commented Dec 4, 2019

This change alters the error message "Missing CNI default network"
because it is sometimes a bit unclear to real user.

@openshift-ci-robot openshift-ci-robot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Dec 4, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2019
@s1061123
Change the message in case of missing CNI files
cc146b3 
This change alters the error message "Missing CNI default network"
because it is sometimes a bit unclear to real user.

Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Dec 4, 2019
@squeed
Copy link
Collaborator

squeed commented Dec 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019
@s1061123
Copy link
Contributor Author

s1061123 commented Dec 4, 2019

@squeed thank you for the review!

saschagrunert
saschagrunert approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too 👍

@s1061123
Copy link
Contributor Author

s1061123 commented Dec 4, 2019

/assign @dcbw

@dcbw
Copy link
Collaborator

dcbw commented Dec 4, 2019

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, s1061123, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit e25b504 into cri-o:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@dcbw dcbw Awaiting requested review from dcbw

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@squeed squeed

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@s1061123 @squeed @dcbw @openshift-ci-robot @saschagrunert @openshift-merge-robot