Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-propagate CWL changes from converted WPS fields #50

Open
3 tasks
fmigneault opened this issue Jul 5, 2019 · 0 comments
Open
3 tasks

Back-propagate CWL changes from converted WPS fields #50

fmigneault opened this issue Jul 5, 2019 · 0 comments
Assignees
Labels
feature/CWL Issue related to CWL support

Comments

@fmigneault
Copy link
Collaborator

fmigneault commented Jul 5, 2019

Description

When complementary details are provided in the WPS deploy body, they are correctly merged with CWL definitions to update the resulting (combined) WPS inputs/outputs information.

On the other hand, these complementary details are not back-propagated into the CWL package definition. Even worst, updated I/O that have their type overriden (ex: from single value to array type because of min/max values), incorrectly preserve the "old" type [#17].

WPS fields that provide missing or overriding information on the CWL side should be applied to update the resulting CWL package.

Adresses issues #17, #31

Extra considerations

  • When multiple formats are specified on the WPS side, updating the CWL formats could be challenging as unknown schema references (i.e.: IANA/EDAM not found) cannot be applied (raises validation error). This means that if any format cannot be found, they cannot be back-propagated from WPS supported_formats definitions as we cannot allow partial definition on CWL side (guaranteed error if the given file is one of the unknown schema that is represented as valid on WPS side).

To Do

@fmigneault fmigneault added triage/bug Something isn't working feature/CWL Issue related to CWL support labels Jul 5, 2019
@fmigneault fmigneault self-assigned this Jul 5, 2019
fmigneault added a commit that referenced this issue Aug 22, 2019
fmigneault added a commit that referenced this issue May 26, 2020
@fmigneault fmigneault removed the triage/bug Something isn't working label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/CWL Issue related to CWL support
Projects
None yet
Development

No branches or pull requests

1 participant