Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make CWL format check against IANA media-type URI more resilient against temporary/sporadic SSL handshake error #707

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

fmigneault
Copy link
Collaborator

Recent (2024-09-93) PRs (#705, #706, etc.) have shown flaky CI testing results due to inconsistent SSL handshake errors from IANA. Avoid this extra validation to fail our pipelines, as they can generally be considered a safe URI location for this specific case.

@fmigneault fmigneault self-assigned this Sep 4, 2024
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/tests Tests of the package and features labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.90%. Comparing base (f1d0463) to head (5af6222).
Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
weaver/formats.py 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
+ Coverage   85.89%   85.90%   +0.01%     
==========================================
  Files          79       79              
  Lines       19067    19070       +3     
  Branches     2958     2960       +2     
==========================================
+ Hits        16378    16383       +5     
+ Misses       1933     1930       -3     
- Partials      756      757       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmigneault fmigneault merged commit 20a5cd8 into master Sep 4, 2024
47 of 48 checks passed
@fmigneault fmigneault deleted the fix-ssl-urlopen branch September 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/tests Tests of the package and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant