Fixes an issue when you pass an url directly. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens for example when you fetch og.likes with a next URL which is already with all the necessary fields in it. With this fix you're able to pass a fully constructed URL (so, in this case, it's merely a wrapper around `request` but it helps when you can use the same API).
NB: might not be the best wording
|
Ah, I see what you mean. I added now a bit of documentation although I'm not particularly happy about it :/ |
criso
added a commit
that referenced
this pull request
Oct 21, 2013
Fixes an issue when you pass an url directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nice for example when you fetch og.likes with
a next URL in the response which has already all the necessary fields in it.
With this fix you're able to pass a fully constructed URL (so,
in this case, it's merely a wrapper around
requestbut ithelps when you can use the same API).