Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added setVersion for setting graph api version #69

Merged
merged 2 commits into from Oct 16, 2014
Merged

added setVersion for setting graph api version #69

merged 2 commits into from Oct 16, 2014

Conversation

chrisjhoughton
Copy link
Contributor

Took me long enough! Apologies for the delay.

@xpepermint commented here regarding also adding the version to the OAuth dialog URLs, which would probably work, but it's not officially recommended or documented in Facebook's docs, so I didn't add it.

Didn't try getting the tests to work as you mentioned they were a little flaky.

@xpepermint
Copy link

@chrisjhoughton I use OAuth dialog (in my own script for now) with version because otherwise you don't get the new facebook view/options.

@chrisjhoughton
Copy link
Contributor Author

You're absolutely right, I'll update accordingly.
On 11 Oct 2014 08:39, "Kristijan Sedlak" notifications@github.com wrote:

@chrisjhoughton https://github.com/chrisjhoughton I use OAuth dialog
(in my own script for now) with version because otherwise you don't get the
new facebook view/options.


Reply to this email directly or view it on GitHub
#69 (comment).

@chrisjhoughton
Copy link
Contributor Author

Ok added the URLs, looks good.

@xpepermint
Copy link

awesome

criso added a commit that referenced this pull request Oct 16, 2014
added setVersion for setting graph api version
@criso criso merged commit 2aa7c7d into criso:master Oct 16, 2014
@criso
Copy link
Owner

criso commented Oct 16, 2014

aww yeah

@criso criso mentioned this pull request Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants