Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specification of supplementary groups to start the JNLP slave with #14

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Allow specification of supplementary groups to start the JNLP slave with #14

merged 1 commit into from
Jan 9, 2019

Conversation

beverage
Copy link

@beverage beverage commented Jan 9, 2019

Specifically to support our docker use case.

Also fixed some rubocop violations.

Allow specification of supplementary groups to start the JNLP slave with
7c3bec7 
Specifically, to support our docker use case internally.
@beverage beverage self-assigned this Jan 9, 2019
emmanuelguerin
emmanuelguerin approved these changes Jan 9, 2019
View reviewed changes
Copy link

@emmanuelguerin emmanuelguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@beverage beverage merged commit 806e8ce into master Jan 9, 2019
@beverage beverage deleted the jenkins-685 branch January 9, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelguerin emmanuelguerin emmanuelguerin approved these changes

Assignees

@beverage beverage

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beverage @emmanuelguerin