Backfills screen improvements #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dufrannea
commented
Aug 3, 2017
dufrannea
commented
- css improvements
- environment name confirmation
- date mask
- css improvements - environment name confirmation - date mask
vguerci
reviewed
Aug 3, 2017
| if (jobs.length <= 0) | ||
| throw new SubmissionError({ _error: "No jobs selected" }); | ||
|
|
||
| return fetch( | ||
| `/api/timeseries/backfill?` + | ||
| `name=${name}&description=${description}&` + | ||
| `jobs=${jobs.join(",")}&priority=${priority}&` + | ||
| `jobs=${jobs.join(",")}&priority=1&` + |
There was a problem hiding this comment.
Are you sure we want to hardcode priority?
dufrannea
force-pushed
the
backfills-improvements
branch
from
f963e29
to
3d1ca47
Compare
vguerci
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.