Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RequestManager TimeInterval #359

Closed
wants to merge 2 commits into from
Closed

Update RequestManager TimeInterval #359

wants to merge 2 commits into from

Conversation

mltbnz
Copy link
Member

@mltbnz mltbnz commented Nov 3, 2020

📝 Docs

📲 What

A description of the change.

🤔 Why

Some background context on why the change is needed.

👀 See

Screenshots, external resources?

  • Added snapshot tests (using iPhone 8 Simulator)
Before 🐛 After 🦋

♿️ Accessibility

  • Tap targets use minimum of 44x44 pts dimensions
  • Works with VoiceOver
  • Supports Dynamic Type

#143

Malte Bünz added 2 commits November 3, 2020 14:24
+ updates the default timeInterval from 12 to 6 seconds when the app is in the foreground
+ when the app receives a failure the refresh interval is set to 4
@mltbnz
Copy link
Member Author

mltbnz commented Nov 3, 2020

This should address #143 but I am not sure if it does since the issue is not fully clear to me... From the Background the app does not send any location update afaik, right? At least from using Proxyman it does not look like it

@mltbnz
Copy link
Member Author

mltbnz commented Mar 8, 2021

lets see when CMs happen again if this can be improved

@mltbnz mltbnz closed this Mar 8, 2021
@mltbnz mltbnz deleted the dynamic-pollrate branch October 22, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant