Don't use callback and Guard with a RwLock the Value inside Entry #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodas
force-pushed
the
no-db-callback
branch
4 times, most recently
from
97853c6
to
e4079f5
Compare
Instead return a reference to the Guarded HashMap and a reference to the Key to be read. Also update Entry to not need a mutable instance ever. Use an internal mutex for the expiration and atomic for the object ids. Do not use time for the object ids, use an atomic counter instead
crodas
force-pushed
the
no-db-callback
branch
2 times, most recently
from
fc5dfd2
to
e037099
Compare
crodas
changed the title
The main goal is to avoid locking the entire slot as Write() to update a single value. Slots should be locked as write to add/remove new keys, not for individual updates. That's suboptimal. A requirement for that is to guard the Value with a RwLock
crodas
force-pushed
the
no-db-callback
branch
from
e037099
to
5e90611
Compare
Non scalar values have a proper locking mechanism inside an Entry, that is enough to drop the former `shared` wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead return a reference to the Guarded HashMap and a reference to the Key to be read