Added Sets support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodas
force-pushed
the
feature/set
branch
14 times, most recently
from
5bda9e1
to
c50a055
Compare
* sdiff * sdiffstore * sinter * sintercard * sinterstore
checksum::Value is only useful when comparing items one by one, like in linked lists. Sets are hashed, so it makes no sense to use checksum::Value, instead Bytes are used. This change will reduce the size of stored items in the set and will avoid cloning data to query the set.
crodas
force-pushed
the
feature/set
branch
2 times, most recently
from
9d31656
to
6e69650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands: