Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Available periods support #106

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Available periods support #106

merged 5 commits into from
Apr 29, 2021

Conversation

AdamWhittingham
Copy link
Contributor

Extend the great work by @kgrab75 on #105 with a test and passing the delete param in the body.
Also prepares the release of v1.3.0

@AdamWhittingham AdamWhittingham marked this pull request as ready for review April 29, 2021 10:37
@AdamWhittingham AdamWhittingham mentioned this pull request Apr 29, 2021
Closed
tomhazledine
tomhazledine approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@tomhazledine tomhazledine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, code looks good, smoke test behaves as-expected 👍

@AdamWhittingham AdamWhittingham merged commit 500592c into master Apr 29, 2021
@AdamWhittingham
Copy link
Contributor Author

@kgrab75 This is now released as v1.3.0, thank you again for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhazledine tomhazledine tomhazledine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamWhittingham @tomhazledine @kgrab75