Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push #footer to the bottom of the page. #15

Merged
merged 4 commits into from
Jan 12, 2015
Merged

Push #footer to the bottom of the page. #15

merged 4 commits into from
Jan 12, 2015

Conversation

chrisvogt
Copy link
Contributor

Fixes #14 by pushing the #footer div to the bottom of the page instead of directly under the content. The footer is static, not fixed. Meaning that it will always remain below the content and no content will flow underneath it.

@rchavik
Copy link
Member

rchavik commented Jan 8, 2015

I'm seeing some strange layout when testing this in my 1366x768 laptop:

docs

Would you be able to address this? I'd really want to fix this too. That footer thing has been bugging me for ages.

@chrisvogt
Copy link
Contributor Author

I'll take a look at that; it was bugging me too. Is that FireFox on Ubuntu?

@chrisvogt
Copy link
Contributor Author

I can't seem to reproduce that. Unless you change the default options I assume your Firefox also auto updates, so we should be using the same version. Hmm, do you have any browser extensions loaded that might be injecting into the scripts, styles, or markup?

@chrisvogt
Copy link
Contributor Author

Chrome, IE, Firefox, Opera on Windows 8.1:
windows-tests

Firefox on Ubuntu 14.04:
screenshot-ff-ubuntu

@rchavik
Copy link
Member

rchavik commented Jan 8, 2015

I retried on Firefox 34.0 in safe mode and still seeing the same problem.

Chrome Version 39.0.2171.95 (64-bit) also looks weird:

chrome-docs

Can you help testing on your end by opening a longer page, eg: appendices/2-2-0-migration-guide.html

@dakota
Copy link
Member

dakota commented Jan 8, 2015

I can confirm this (Chrome 40)

image

Problem is with long pages, the footer doesn't stay stuck to the bottom, rather it remains at the original position.

@chrisvogt
Copy link
Contributor Author

Ah, that one doesn't appear right either, but now only on short pages. Setting the height on #main to 100% helps, but then it gets pushed down too far and the page always scrolls. This footer is frustrating, I need to step away from it for a couple hours. I'll give it another shot later and message in when I figure it out.

@chrisvogt
Copy link
Contributor Author

Looking good now. Also took care of the theme.css and pygments.css assets being double-loaded. (You can see this if you check out the <head> of the production docs right now.)

@rchavik
Copy link
Member

rchavik commented Jan 9, 2015

I'll pull this in this weekend.

Thank you so much ! 🍻

@rchavik rchavik merged commit 18540bd into croogo:master Jan 12, 2015
@rchavik
Copy link
Member

rchavik commented Jan 12, 2015

This is now merged and in production.

I apologize for the delay.

Thank you!

@chrisvogt
Copy link
Contributor Author

Looking good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push footer to bottom of the page
3 participants
@chrisvogt @rchavik @dakota