Latest update crashes Silent Hill 2 in SetVertexShader()

[elishacloud]

The latest check-in from PR #158 crashes Silent Hill 2 in SetVertexShader() after changing resolutions.

As far as I can tell Silent Hill 2 does not recreate Vertex or Pixel shaders after a Reset(). It seems that Silent Hill 2 assumes that the shaders are still available even after the Reset().

Sometimes Microsoft's documentation is wrong. It seems like this may be the case here because Silent Hill 2 reuses shaders created before the Reset().

[HerMajestyDrMona]

For me Empire Earth 2 crashes after using the ALT+ENTER hotkey (switching between the windowed / full screen mode). It only happens in the started game (not in the menu). I assume the reason is the same, even though changing screen resolution seem to work.
EDIT:
Yeah, disabling function Direct3DDevice8::ReleaseShaders() fixes it.

[nv-ajaus]

Addressed this in #161 , I was wondering if this was related to D3D8 mixing FVF calls and programmable shader creation together in CreateVertexShader(), or something to do with the Vertex Declaration objects created in d3d8to9 but it seems some d3d8 applications just use shaders across a D3DERR_DEVICELOST return from Present() and Reset().

[elishacloud]

Yeah, Microsoft's documentation is not always correct with these older DirectX APIs. I run into this from time-to-time.

[CookiePLMonster]

Yeah, Microsoft's documentation is not always correct with these older DirectX APIs. I run into this from time-to-time.

FWIW MS folks who own DirectX-related pages are one of the most responsive out of all docs maintainers so if you submit a doc fix they will certainly take a look.