Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo #1524

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fixed a typo #1524

merged 1 commit into from
Jul 9, 2024

Conversation

adamperkowski
Copy link
Contributor

In Installation section of README
'using' -> 'use'

in Installation section
'using' -> 'use'
@adamperkowski adamperkowski requested a review from a team as a code owner July 8, 2024 17:06
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Jul 8, 2024
@Emilgardis
Copy link
Member

is this actually a typo?

to me using makes sense in this context

@adamperkowski
Copy link
Contributor Author

Well, using in a sentence should be followed by a verb to actually tell what are you using. For example:

She is using a pen to write something.

The correct structure would be to use use after or to maintain parallel structure in the sentence. (just looked that up)

... to directly download the pre-compiled release binaries or to use ... would be correct too.

@Emilgardis
Copy link
Member

the intended meaning of the or is

"You can also install cross via the precompiled binaries from our github releases or use cargo-binstall"

maybe that's a better way to phrase it?

@Emilgardis
Copy link
Member

if you disagree with that i'm fine accepting this pr :)

@adamperkowski
Copy link
Contributor Author

I don't disagree. I understand the meaning. In fact,

You can also install cross via the precompiled binaries from our github releases or use cargo-binstall

you did the same thing as me here, just changed the first part of the sentence (download -> install cross via) and you used use.
So I don't disagree, I'm fine with you accepting this pr or just changing it by yourself.

@Emilgardis
Copy link
Member

Alright, lets do it this way then! Thank you!

@Emilgardis Emilgardis added this pull request to the merge queue Jul 9, 2024
@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect any cross-compilation targets. label Jul 9, 2024
@Emilgardis Emilgardis removed this pull request from the merge queue due to a manual request Jul 9, 2024
@Emilgardis Emilgardis added this pull request to the merge queue Jul 9, 2024
Merged via the queue into cross-rs:main with commit 33c4d26 Jul 9, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog A valid PR without changelog (no-changelog) no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants