Add integration tests.

[Alexhuszagh]

Adds an an integration test for remote Docker support with and without persistent data volumes, and adds it to CI. In addition, we've added integration tests for custom toolchains using cargo-bisect-rustc. Also changes the workflow to ensure publish depends on fmt, clippy, and cargo-deny. Fixes a bug when removing data volumes, since it does not require a target.

[Alexhuszagh]

Since this would slow down our CI by quite a bit by default (bisect took 8 min, remote took 4 min), while most of our other actions take ~1m or less, I've changed it so it only runs if we use bors, so this works on PRs or if we try. (I'm using an invalid target here intentionally).

bors try --target x

[Alexhuszagh]

https://app.codecov.io/gh/cross-rs/cross/compare/873/tree/src/docker/shared.rs#D1L891 see coverage

Ah that's unusual. Not sure why that's the case, it should be defining HOSTNAME inside the image. I guess the diagnostics are good, then.

[Emilgardis]

Aha, I get it now!

You'll have to forward RUSTFLAGS inside the containered container, it's probably doing everything correct just not providing coverage.

See https://github.com/cross-rs/cross/runs/7169840511?check_suite_focus=true#step:19:22 where there's no profraw files and https://github.com/cross-rs/cross/runs/7169840371?check_suite_focus=true#step:10:7 where there is

[Emilgardis]

hmm, still not working

      Running `CARGO_INCREMENTAL=0 /home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin/llvm-profdata merge -sparse -o /home/runner/work/cross/cross/target/cross.profdata`
added 18 packages, and audited 19 packages in 1s
2 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
added 3 packages, changed 3 packages, and audited 22 packages in 360ms
3 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
error: no input files specified. See llvm-profdata merge -help

I don't know why.

[Alexhuszagh]

I have no idea either, I might need to also forward all of these as well:

• LLVM_PROFILE_FILE
• CARGO_INCREMENTAL
• RUST_TEST_THREADS

[Emilgardis]

oh.. ofc, need to forward LLVM_PROFILE_FILE too...

[Emilgardis]

Incremental would be good to disable, as we don't use the incremental data

[Alexhuszagh]

Incremental would be good to disable, as we don't use the incremental data

I've just forwarded everything, since if they're provided by the action, there's probably a good reason for them.

bors try --target aarch64-unknown-linux-gnu

[Alexhuszagh]

Code coverage still isn't working. At least the code tests to work on my machine.

[Emilgardis]

We need to make the target folder available at the same path/the path in LLVM_PROFILE, easiest solution is to do -v /home/runner/work/cross/cross/target/:/home/runner/work/cross/cross/target/

edit: if we also do -v /home/runner/work/cross/cross/target/:/project/target we will get cache

[Alexhuszagh]

bors try --target aarch64-unknown-linux-gnu

[bors]

try

Build succeeded:

• conclusion

[Alexhuszagh]

Nothing is working so I'm going to throw in a panic and see if it just "works".

[Alexhuszagh]

Let's see if it panics:
bors try --target aarch64-unknown-linux-gnu

[Emilgardis]

It is working, no? https://github.com/cross-rs/cross/runs/7170509736

[Alexhuszagh]

It is working, no? https://github.com/cross-rs/cross/runs/7170509736

Wait it is, maybe the code coverage I got was outdated. I'll squash the commits into one.

[bors]

try

Build succeeded:

• conclusion

[Emilgardis]

bors r+

awesome

[bors]

Build succeeded:

• conclusion