updated controller to reflect muvaf PR comments

Signed-off-by: Krish Chowdhary <krish@redhat.com>

pkg/controller/s3/s3bucketpolicy/s3bucketpolicy.go

@@ -119,17 +119,10 @@ func (e *external) Observe(ctx context.Context, mgd resource.Managed) (managed.E
 
 	cr.SetConditions(runtimev1alpha1.Available())
 
-	if !cmp.Equal(*policyData, *resp.Policy) {
-		return managed.ExternalObservation{
-			ResourceExists:   true,
-			ResourceUpToDate: false,
-		}, nil
-	}
-
 	// If our version and the external version are the same, we return ResourceUpToDate: true
 	return managed.ExternalObservation{
 		ResourceExists:   true,
-		ResourceUpToDate: true,
+		ResourceUpToDate: cmp.Equal(*policyData, *resp.Policy),
 	}, nil
 }
 
@@ -198,8 +191,7 @@ func (e *external) Update(ctx context.Context, mgd resource.Managed) (managed.Ex
 		return managed.ExternalUpdate{}, errors.Wrap(err, errUpdate)
 	}
 
-	policyString := *policyData
-	_, err = e.client.PutBucketPolicyRequest(&awss3.PutBucketPolicyInput{Bucket: aws.String(cr.Spec.PolicyBody.BucketName), Policy: aws.String(policyString)}).Send(context.TODO())
+	_, err = e.client.PutBucketPolicyRequest(&awss3.PutBucketPolicyInput{Bucket: aws.String(cr.Spec.PolicyBody.BucketName), Policy: aws.String(*policyData)}).Send(context.TODO())
 	return managed.ExternalUpdate{}, errors.Wrap(err, errUpdate)
 }