Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDS Modify call is made in each reconcile when ApplyModificationsImmediately is true #63

Closed
muvaf opened this issue Oct 31, 2019 · 1 comment
Closed

RDS Modify call is made in each reconcile when ApplyModificationsImmediately is true #63

muvaf opened this issue Oct 31, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@muvaf
Copy link
Member

muvaf commented Oct 31, 2019

What happened?

When spec.forProvider.ApplyModificationsImmediately is true, the patch object includes ApplyImmediately all the time because that doesn't exist in the corresponding SDK object. Details noted here https://github.com/crossplaneio/stack-aws/blob/master/pkg/clients/rds/rds.go#L444

How can we reproduce it?

ApplyModificationsImmediately is true by default. So, just creating an RDS instance and putting a breakpoint on the Update call of the ExternalClient would show you.

What environment did it happen in?

Crossplane version: 0.4.0
@muvaf muvaf added the bug Something isn't working label Oct 31, 2019
@ActuallyTrent ActuallyTrent mentioned this issue Sep 3, 2020
Merged
4 tasks
@muvaf
Copy link
Member Author

muvaf commented Feb 24, 2021

This seems to be fixed by ignoring that field in comparison.

@muvaf muvaf closed this as completed Feb 24, 2021
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this issue Mar 12, 2024
@muvaf
Merge pull request crossplane-contrib#63 from hasheddan/new-up-who-dis
783ad71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@muvaf