[release-0.18] Bump crossplane-runtime to v0.13.1 #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes crossplane-contrib#802 See https://github.com/crossplane/crossplane-runtime/releases/tag/v0.13.1 Signed-off-by: Nic Cope <negz@rk0n.org>
This means we'll wait three minutes from the time a resource was most recently created before we trust the EC2 API if/when it indicates the resource doesn't exist. Signed-off-by: Nic Cope <negz@rk0n.org>
negz
changed the title
hasheddan
approved these changes
Sep 8, 2021
Signed-off-by: Muvaffak Onus <me@muvaf.com>
crossplane-contrib@2c73c90, I'm blindly copying this from the above commit. It's the only difference I can find between master (where e2e tests pass) and release-0.18 (where they don't). Signed-off-by: Nic Cope <negz@rk0n.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes #802 for the v0.18 release. See https://github.com/crossplane/crossplane-runtime/releases/tag/v0.13.1 and crossplane/crossplane-runtime#283 for more detail.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I tested this change extensively as part of crossplane/crossplane-runtime#283. I've run a cursory version of the same test on this specific PR (i.e. spun a composition of EC2 resources up and down once).