Add messageRetentionDuration to PubSub Topic #440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #422
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
messageRetentionDuration
field using the managed resourceImportant note for reviewers
Currently, it is possible to use a fractional number in the
messageRetentionDuration
field, for example: 1200.5s.This will cause an update-loop in the managed resource, because the API returns the value as
1200.500s
, which is "different" in our comparisons.This bug won't appear if the platform builder uses an integer, for example,
1200s
. In this case, the GCP API will return1200s
and it will be considered up to date.I decided to not include this parser to include zeros/exclude zeros after the dot before the comparisons for simplicity for now, but if you think it is crucial for this feature, please request changes :)