-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bundled packages and update CI to dual publish to DockerHub and Upbound Marketplace #456
Use bundled packages and update CI to dual publish to DockerHub and Upbound Marketplace #456
Conversation
Drops all deprecated annotations from the provider-aws crossplane.yaml. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Drops the spec from the crossplane.yaml as bundled images will now be used for provider-aws. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Renames the single image that is being built as base to provider-gcp. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates package base image to use distroless static nonroot instead of defaulting to outdated alpine image. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates provider controller image building to use imagelight for enhanced flexibility. Publish and promotion is deferred to xpkg machinery. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Adds the xpkg machinery to Makefile and updates other components to be compatible. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates integration tests to consume the xpkg image that is built. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates build submodule to consume latest updates, including xpkg.mk. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Forces image to be built before building xpkg, ensuring that the image is in the daemon before we try to use it as base. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Adds a login step to publish artifacts workflow for xpkg.upbound.io. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See crossplane-contrib/provider-aws#1460 for similar functionality in provider-aws
.
Updates to go1.18 and fixes all linter errors introduced by the golangci-lint bump. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates integration tests to go back to using the latest stable version of Crossplane. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a small comment
spec: | ||
controller: | ||
image: DOCKER_REGISTRY/provider-gcp-controller:VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just curious. If I understand it correctly, now the provider and the controller are the same image. This means that the Provider
kind doesn't need to specify the spec.controller.image
field.
Looking at the doc.crds, I saw that the field spec.controller
is still required:
So a valid specification of Provider
would be:
apiVersion: meta.pkg.crossplane.io/v1
kind: Provider
metadata:
name: provider-gcp
spec:
controller: {}
This means that provider-gcp version v0.21.0
(latest) and earlier should specify spec.controller.image
, v0.22.0
(release that should include this PR) doesn't need to specify it. Am I right? Just wondering if we should write this in the Release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Feggah I think it would be worth including this update in the release notes, but it shouldn't have too much of an impact on users as they aren't actually constructing the meta.pkg.crossplane.io
types 👍🏻
username: ${{ secrets.XPKG_ACCESS_ID }} | ||
password: ${{ secrets.XPKG_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these need to be created at the crossplane-contrib org level? I don't see them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@negz I have created these tokens for provider-aws
/ provider-gcp
/ provider-azure
in each individual repo with scope limited to the individual repositories -- happy to broaden permissions and set at org level if you prefer (I feel like we had this same conversation a few years ago 🙂 )
Description of your changes
Drops all deprecated annotations from the provider-aws crossplane.yaml.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Drops the spec from the crossplane.yaml as bundled images will now be
used for provider-aws.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Renames the single image that is being built as base to provider-gcp.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates package base image to use distroless static nonroot instead of
defaulting to outdated alpine image.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates package base image to use distroless static nonroot instead of
defaulting to outdated alpine image.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Adds the xpkg machinery to Makefile and updates other components to be
compatible.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Updates integration tests to consume the xpkg image that is built.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Adds a login step to publish artifacts workflow for xpkg.upbound.io.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Fixes #453
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Published image contents: https://explore.ggcr.dev/?image=hasheddan%2Fprovider-gcp%3Av0.22.0