fix(service-integration): write integration_key into connection details secret #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls secret Signed-off-by: Holger Johannes Heinz <79228197+holgerjh@users.noreply.github.com>
haarchri
approved these changes
Nov 16, 2023
holgerjh
deleted the
feature/write-integration-key-into-connection-secret
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR lets
integration.service.pagerduty.crossplane.iowrite theintegrationKeyinto the connection secret specified bywriteConnectionSecretToRef. This is especially useful when a new api key is requested and should be consumed by objects that read it from a secret, such as e.g. Grafana ContactPoints.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Run provider and created an Integration with
writeConnectionSecretToRefset to a secret, then checked the secret.