-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build+publish process and use bundled packages #24
Update build+publish process and use bundled packages #24
Conversation
Signed-off-by: Jason Tang <jason@upbound.io>
TODO:
|
Signed-off-by: Jason Tang <jason@upbound.io>
Signed-off-by: Jason Tang <jason@upbound.io>
@@ -149,7 +149,7 @@ func generateDataSource(resp *models.DatasourcesV1DatasourcesGetResponseResult) | |||
} | |||
|
|||
func generateDurationFromSeconds(seconds int64) *metav1.Duration { | |||
d := (time.Duration)(seconds) * time.Second | |||
d := (time.Duration)(seconds) * time.Second //nolint:durationcheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a false positive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jastang! Secrets updated 👍🏻
@jastang looks like we'll need to bring in similar changes to https://github.com/crossplane-contrib/provider-aws/pull/1460/files#diff-b051933e1c5ed7533648af4517ede8d50df55b68a56c44e6094d3019595abcf2 here. |
Signed-off-by: Jason Tang <jason@upbound.io>
thanks @hasheddan -- the workflow didn't trigger again, but not sure if it's related to the current Actions outage |
@jastang looks like it might be 👍🏻 I feel good about merging here, but let's wait until actions are back online so we can ensure publish works |
Signed-off-by: Jason Tang jason@upbound.io
Description of your changes
Updates the build machinery to use bundled packages, as well as publish to
crossplane-contrib
OCI repos in both DockerHub and Upbound registries.xref crossplane/crossplane#3350
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Build
Publish
Check