-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EquateParameters cmp helper #114
Comments
Hi @negz, is this issue still valid ?? If yes, I would like to work on this. |
I believe so! CC @muvaf who may have an opinion here. |
Thanks, I will pick this up then. |
Hi! I think |
Thanks @muvaf, will keep it in mind. Excited to try working on this repo. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as |
What problem are you facing?
https://github.com/crossplaneio/stack-gcp/pull/151/files?file-filters%5B%5D=.go#diff-888e0ec46a21ebd2bbdc8d86d4553d9bR92
We frequently use the above
cmpopt
when determining whether managed resources are equivalent in theIsUpToDate
method of each resource's controller. The readability of this option is a little opaque in how it relates to Crossplane.How could Crossplane help solve your problem?
Perhaps we should add a function like our existing
EquateErrors
that equates managed resource parameters? This could just be an abstraction onIgnoreInterfaces
to begin with.The text was updated successfully, but these errors were encountered: