Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Reorg for v1.11 #271

Merged
merged 47 commits into from
Jan 31, 2023
Merged

Docs Reorg for v1.11 #271

merged 47 commits into from
Jan 31, 2023

Conversation

plumbis
Copy link
Collaborator

@plumbis plumbis commented Jan 13, 2023

This is a rework of PR #254.

Summary of changes

  • The creation of a "Knowledge Base" for content that is not version specific and can be more in depth on a single topic or cross multiple topics.

  • The creation of a "Developer Guide" covering contributing to the Crossplane docs and a pointer to the crossplane/crossplane CONTRIBUTING.md

  • A significant reorganization of files within a docs version. This reorg is currently only for the master branch docs and will be applied to version v1.11 and new versions going forward. Existing version pages will not be changed (read: no broken bookmarks)

Changes from #254

Work in progress

A few things are still required to have MVP content for v1.11's release:

  • Install/Uninstall/Upgrade chapters need to be written
  • Quickstart guides need to be reviewed extended to include XRs and Claims

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 80d9a42
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/63d994bc1ee0b70008a38ba4
😎 Deploy Preview https://deploy-preview-271--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
@burnyd
Copy link

burnyd commented Jan 19, 2023

LGTM! Nice examples and explanations.

Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
@jeanduplessis
Copy link
Collaborator

@plumbis this PR, #267, still needs to be merged but mentioned in the description that it should already be merged.

content/knowledge-base/_index.md Outdated Show resolved Hide resolved
content/knowledge-base/_index.md Outdated Show resolved Hide resolved
themes/geekboot/layouts/partials/docs-sidebar.html Outdated Show resolved Hide resolved
@jeanduplessis
Copy link
Collaborator

jeanduplessis commented Jan 24, 2023

@plumbis I'm struggling to make sense of the new information architecture with regards to Documentation, Contributing Guide and Knowledge Base.

For instance if I'm on the Documentation overview, I don't see any way of accessing the Contribution Guide or Knowledge Base?
CleanShot 2023-01-24 at 15 23 33@2x

And if I'm on the Knowledge Base I don't see how it fits into the overall Documentation, since the left nav is totally different. Same for Contributing Guide.

CleanShot 2023-01-24 at 15 22 10@2x

CleanShot 2023-01-24 at 15 23 54@2x

What are the expected user journeys that get you to the new Knowledge Base and Contributing Guide sections and how does it relate to the overall Documentation section?

@jeanduplessis
Copy link
Collaborator

CleanShot 2023-01-24 at 15 13 59@2x

It would be good if we can fix the spacing for the items below the "On this page" right hand menu.

plumbis and others added 3 commits January 24, 2023 09:33
Signed-off-by: Pete Lumbis <pete@upbound.io>

Co-authored-by: Jean du Plessis <jean@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
@plumbis
Copy link
Collaborator Author

plumbis commented Jan 24, 2023

@jeanduplessis just pushed a fix for the spacing between github buttons with e67e63c

@jbw976
Copy link
Member

jbw976 commented Jan 31, 2023

@jeanduplessis just pushed a fix for the spacing between github buttons with e67e63c

I still see a lack of spacing when looking just now at the deployment preview and doing a hard refresh, e.g. https://deploy-preview-271--crossplane.netlify.app/v1.11/. I wouldn't block the PR on it, but curious why it doesn't appear fixed for me.

Screenshot 2023-01-31 at 10 31 32 AM

Signed-off-by: Pete Lumbis <pete@upbound.io>
@plumbis
Copy link
Collaborator Author

plumbis commented Jan 31, 2023

@jeanduplessis just pushed a fix for the spacing between github buttons with e67e63c

I still see a lack of spacing when looking just now at the deployment preview and doing a hard refresh, e.g. https://deploy-preview-271--crossplane.netlify.app/v1.11/. I wouldn't block the PR on it, but curious why it doesn't appear fixed for me.

Screenshot 2023-01-31 at 10 31 32 AM

That was originally for vertical spacing and I didn't notice the horizontal spacing. Just pushed a fix.

Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
…that version

Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plumbis in general, the new docs site and content is looking fantastic!! 🔥

there may be some parts of the details and flow that we want to tweak after running through them more completely in the near future, but overall I don't see major show stoppers in this new docs experience that would prevent us from shipping today. we can make tweaks as they come up via feedback in the near future.

i'm still a bit confused (and potentially concerned) about how the maintenance and backporting of updates to the docs content will work, but I think that's also out of scope for this PR and that decision was already made when moving the docs out of the c/c repo. Perhaps pointing me to the process/instructions for backporting will be helpful.

Thank you again for this massive effort and making the crossplane docs better @plumbis!! 💪

Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
@plumbis
Copy link
Collaborator Author

plumbis commented Jan 31, 2023

@jbw976

i'm still a bit confused (and potentially concerned) about how the maintenance and backporting of updates to the docs content will work, but I think that's also out of scope for this PR and that decision was already made when moving the docs out of the c/c repo. Perhaps pointing me to the process/instructions for backporting will be helpful.

All of the docs across every version lives inside the /content directory. To backport a fix you just edit the same file in the other directory. For example, fixing a problem in /getting-started/_index.md would mean the same fix is applied to /content/v1.11/master/getting-started/_index.md and /content/master/getting-started/_index.md.

This is mentioned briefly in the new contributors guide
https://deploy-preview-271--crossplane.netlify.app/contribute/contribute/#contribute-to-a-specific-version

(this link won't work until this is PR is merged)
https://docs.crossplane.io/contribute/contribute/#contribute-to-a-specific-version

@negz
Copy link
Member

negz commented Jan 31, 2023

Just to be explicit - feel free to proceed without my approval. I haven't had time to review this deeply. I feel okay about following up with any changes post release.

@negz
Copy link
Member

negz commented Jan 31, 2023

Screenshot 2023-01-31 at 1 53 17 PM

I will note though I'm currently seeing "User Documentation" written twice.

Signed-off-by: Pete Lumbis <pete@upbound.io>
@plumbis
Copy link
Collaborator Author

plumbis commented Jan 31, 2023

"User Documentation User Documentation" was because master had the wrong version number. Fixed.

@jbw976
Copy link
Member

jbw976 commented Jan 31, 2023

Note that DCO was manually approved because of https://github.com/crossplane/docs/pull/271/checks?check_run_id=10851743149

There's a discrepancy in @plumbis sign-off for a commit from Github. However, the intent of the DCO is met: pete@upbound.io signed-off for plumbis@users.noreply.github.com. It would be nice to update the commit metadata to make it perfectly matching, but that proved difficult to update because there are merge commits after that commit that had conflicts.

We are moving forward with a manual DCO approval because the DCO intent is met.

@plumbis plumbis merged commit 85407e8 into crossplane:master Jan 31, 2023
@plumbis plumbis deleted the reorg-v3 branch January 31, 2023 23:59
@negz negz mentioned this pull request Feb 2, 2023
plumbis pushed a commit that referenced this pull request Feb 9, 2023
plumbis pushed a commit to plumbis/crossplane-docs that referenced this pull request Feb 12, 2023
plumbis added a commit to plumbis/crossplane-docs that referenced this pull request Mar 6, 2023
Signed-off-by: Pete Lumbis <pete@upbound.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants