fix: Objects with .status: {} should return Healthy #746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the health status for
ProviderConfig
objects, that kept being reported as Progressing in ArgoCD.The reason is that the script was only checking for
nil
values in the status and conditions fields. In Lua, an empty table is not the same asnil
. In theProviderConfig
object, thestatus
field is an empty objectstatus: {}
.This fix extends the conditions to also catch when the field field exists but is empty, by using the
next
function to returnnil
if the table is empty. The ProviderConfig is now showing healthy!