Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design-doc about the Uptest improvements #10

Merged

Conversation

sergenyalcin
Copy link
Member

Description of your changes

This PR adds a design-doc about the Uptest improvements. This design-doc will be a guideline for the Uptest v1.0.0 version.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@jeanduplessis
Copy link
Collaborator

@sergenyalcin, as discussed today, let's break this proposal into two parts:

  1. The consideration around which test framework to use
  2. The capability expansion of Uptest.

For the test framework, let's indicate the proposed framework to use and add a summary of what led to this recommendation.

For the capabilities, lets add some examples of how the API might look that enables these from an end-user pov.

@sergenyalcin sergenyalcin force-pushed the uptest-improvements-design-doc branch from 189b79a to 038d615 Compare March 27, 2024 09:32
@sergenyalcin sergenyalcin changed the title Add design-doc about the Uptest improvements Add design-doc about the Uptest improvements and add a one-pager about the consideration around which test framework to use Mar 27, 2024
@sergenyalcin
Copy link
Member Author

@jeanduplessis completed your comments. Now the PR is open for review

@sergenyalcin sergenyalcin marked this pull request as ready for review March 27, 2024 09:33
@sergenyalcin sergenyalcin force-pushed the uptest-improvements-design-doc branch from 038d615 to c4ac9c9 Compare March 27, 2024 09:59
@sergenyalcin sergenyalcin changed the title Add design-doc about the Uptest improvements and add a one-pager about the consideration around which test framework to use Add design-doc about the Uptest improvements Mar 27, 2024
@sergenyalcin
Copy link
Member Author

One-pager about "The consideration around which test framework to use": #11

@sergenyalcin
Copy link
Member Author

@jeanduplessis, thanks for your review. I have addressed your comments and answered the necessary ones.

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
-Remove unncesseary parts of document for clear expression

-Combine release tests and diff tests

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin sergenyalcin force-pushed the uptest-improvements-design-doc branch from be7c453 to 0495c50 Compare May 13, 2024 08:50
@sergenyalcin sergenyalcin merged commit 797743a into crossplane:main May 13, 2024
6 checks passed
@sergenyalcin sergenyalcin deleted the uptest-improvements-design-doc branch May 13, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants