Add support for scrolling left and right. #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimonPost
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Would be nice if we can also add support for windows, do you have a windows machiene, otherwise i can push to this pr https://learn.microsoft.com/en-us/windows/win32/inputdev/wm-mousehwheel
I added support for windows. Altough, for some reason, I dont get any events from winapi if I use my third mouse button to scroll horizontally. Not sure why it is not working.
|
I formatted your changes as required by the repository. Great to see some support on windows as well. Would you say it’s ok to merge or is additional support for windows required (eg your comment regarding third mouse button)? I don’t have a windows system to test side scrolling unfortunately. |
TimonPost
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossterm does not currently support left and right scrolling. This PR fixes that.