Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tabs more like browsers do #1147

Closed
10 tasks done
nwalkewicz opened this issue May 19, 2024 · 6 comments · Fixed by #1149
Closed
10 tasks done

Handle tabs more like browsers do #1147

nwalkewicz opened this issue May 19, 2024 · 6 comments · Fixed by #1149

Comments

@nwalkewicz
Copy link
Contributor

nwalkewicz commented May 19, 2024

I would love to see tabs handled in the same way as modern browsers. Here are some examples:

  • Open verses in a new tab via context menu or middle click (specifically in the Verse List panel, but maybe there are other places that make sense, too)
  • Move existing tabs around by either click-and-drag or Ctrl+Shift+[PgUp/PgDown]
  • Close existing tabs via middle click (anywhere on the tab) or Ctrl+W
  • Re-open closed tabs via Ctrl+Shift+WT (not as desirable as the others)

These changes would help power users navigate around more quickly, as they are used to with their browser.


Edit: I've started work on this and have created the following checklist for myself and others to keep track of my progress. I'll be ignoring Ctrl+Shift+WT for now due to my unfamiliarity with the project.

  • Rearrange tabs by click-and-drag
  • Middle click to open in new tab (already done by someone else, thank you!)
  • Middle click any tab to close it
  • Click "X" icon on any tab to close it, not just the current tab
  • Shortcuts
    • Ctrl-W: Close current tab
    • Ctrl-Tab / Ctrl-PgDown: Navigate to next tab
    • Ctrl-Shift-Tab / Ctrl-PgUp: Navigate to previous tab
    • Ctrl-Shift-PgDown: Reorder current tab to the right
    • Ctrl-Shift-PgUp: Reorder current tab to the left
@LAfricain
Copy link
Contributor

LAfricain commented May 19, 2024

You have a similar issue here. @karlkleinpaste seems duplicated.

@nwalkewicz
Copy link
Contributor Author

You have a similar issue here.

@LAfricain You're right, someone already made the tab rearrangement suggestion in that issue, but it seems to be an afterthought ("Another cool feature [...] This too would be a useful enhancement...").

This issue puts a primary focus on that feature, along with other related suggestions that aren't mentioned elsewhere. I think the rearrangement suggestion makes sense in this issue; my goal is to focus on the more general topic of "Tab Management".

@LAfricain
Copy link
Contributor

LAfricain commented May 19, 2024

my goal is to focus on the more general topic of "Tab Management".

Do you plan to develop this? Any help is welcome.

This issue puts a primary focus on that feature

I pointed out the duplication, to avoid adding unnecessary issues to the list, and thus facilitate the search. As far as I'm concerned, we can close the other issue and leave this one open. @karlkleinpaste will decide.

@nwalkewicz
Copy link
Contributor Author

I pointed out the duplication[... to] facilitate the search.

I apologize, I misunderstood your first comment; thank you for clarifying.

Do you plan to develop this? Any help is welcome.

I'd love to take on the challenge, but I've never worked with GTK before and it would be quite the learning curve for me. Regardless, I'm happy to learn it and put effort towards it, but it would probably take a while.

@LAfricain
Copy link
Contributor

Congratulations!

@nwalkewicz
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants