This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were disabling it based on some documentation:
http://docs.openstack.org/admin-guide-cloud/content/ch_introduction-to-openstack-compute.html
("Packet loss from instances to nova-network server (VLANManager mode)") and
But it turns out this was misunderstood: the documentation was advising
to do it only on the nova-network node (which would be the neutron l3
node today). On the compute nodes, we absolutely need netfilter on
bridges to get security groups working.
For now, we simply enable this everywhere as, based on testing, this
doesn't seem to hurt us, and it should be safer this way on other nodes
too.