Pacemaker cookbook #17
Conversation
for RHEL platform_family - Add the LICENSE file - Add berks and test-kitchen config which are needed for cookbook testing
platform_family. The version is kept at '0' on suse but on RHEL version '1' is used. - Reformat the template content
…ing compilation phase when authey is nil
…n. Minor code formatting.
… required packages
… corosync init script that was being setup for non-suse platforms only needs to be setup for debian based distros
…ore than 1 instances so that they can communicate with each other
contain shell escape sequence and parsing will fail.
…therwise compilation of recipe fails
…e from rspec-mocks' old syntax.
| Chef::Log.error("Global options needs to be a Hash of the format: { 'option' => 'value' }. Please set node['haproxy']['global_options'] accordingly.") | ||
| end | ||
|
|
||
| template "#{node['haproxy']['conf_dir']}/haproxy.cfg" do |
There was a problem hiding this comment.
Style/StringLiteralsInInterpolation: Prefer double-quoted strings inside interpolations.
|
@aspiers is there anything I can do here? |
|
@aspiers this looks like its still blocked for some reason. Anything you want me to do here? |
|
@ovaistariq As first step it would be create if you can fix all the hound style issues. |
|
@ovaistariq I'm so sorry for the delay - I keep meaning to look at this but I've been really struggling with workload so keep having to postpone. @rsalevsky is right that it would be very helpful if you could fix the Hound CI style warnings; also I see that the branch now has conflicts so will need rebasing. Also I have just submitted #30 which will help increase confidence that your changes won't introduce any regressions on our side. |
|
#30 has now been merged so please rebase this PR on top of that to ensure the test suite gets run by Travis. Thanks again! |
|
If this should be still interesting please rebase and reopen. |
Fixes #16