Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/git tag detection in Makefile is wrong #1234

Closed
mmetc opened this issue Feb 2, 2022 · 0 comments
Closed

Bug/git tag detection in Makefile is wrong #1234

mmetc opened this issue Feb 2, 2022 · 0 comments
Labels
kind/bug Something isn't working

Comments

@mmetc
Copy link
Contributor

mmetc commented Feb 2, 2022

Describe the bug

The Makefile sets BUILD_VERSION to the last tag I created, even if it has nothing to do with the branch I am on.
The behavior is the same in the firewall bouncer.

To Reproduce

$ git checkout some-branch
$ git tag -a -m blah-blah blah-blah
$ git checkout master
$ git describe --tags `git rev-list --tags --max-count=1`
blah-blah
$ git describe --tags                                    
v1.3.0-28-gead0a06f

Since I prepare freebsd tags on a Linux machine, all my Linux (local) builds have a freebsd tag as well, with a wrong version too.

Expected behavior

I would expect a BUILD_VERSION with a tag that appears in the commit history of the branch I am building.
The BUILD_TAG is correct.

@mmetc mmetc added the kind/bug Something isn't working label Feb 2, 2022
mmetc added a commit that referenced this issue Feb 15, 2022
@mmetc mmetc closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant