Improve distinct/uniq behaviour #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlteredCoder
approved these changes
Apr 25, 2022
mmetc
pushed a commit
that referenced
this pull request
May 19, 2022
* make uniq/distinct use a cache that is independant of the bucket's cache_size * add testing specifically for cache_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing implementation,
distincteffectiveness is directly related to thecache_sizeparameter. Thedistinctparses in "live" the queue of objects to determine the uniqueness. For a scenario such ascrawl-http-non-statics, this can have a "huge" impact in terms of potential false-positives. This PR adds its own cache to thedistinctfilters, so that it's not impacted by the cache_size.