Memory check for cscli dashboard setup #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 7, 2022 16:52
…s flag cause they already provided it
LaurenceJJones
commented
May 7, 2022
buixor
requested changes
May 9, 2022
Since checking the RAM is not required to get the container up and running we can change this to a warn level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If total memory < 1GB and force-yes is not provided the user can answer Y/n to continue running the Metabase container if the force-yes flag is provided it will just warn the user that Metabase container requires 1-2GB
Please note the current calculation of memory is set to 1GB as per issue, however, in crowdsec documentation it states 1-2GB
EDIT: The free system memory function was acting a bit strange on my VM it listed only 57MB free instead of 570MB so for the first implementation I thought total memory can be an improvement.
I have done some more testing and the free memory is correct for my VM after system allocation. I can update this PR with the check for free system memory check as well, however, I will wait for feedback.
#826