Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: replace cp -an with rsync to allow bind-mount of files in /etc/crowdsec #2611

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 22, 2023

For #2480

The alternative - without this change - is to mount inside /staging/etc/crowdsec instead of /etc/crowdsec

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a51bce8) 56.73% compared to head (45b1e02) 56.87%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2611      +/-   ##
==========================================
+ Coverage   56.73%   56.87%   +0.14%     
==========================================
  Files         186      190       +4     
  Lines       25783    26169     +386     
==========================================
+ Hits        14628    14884     +256     
- Misses       9633     9730      +97     
- Partials     1522     1555      +33     
Flag Coverage Δ
bats 38.53% <ø> (-0.02%) ⬇️
unit-linux 55.23% <ø> (+0.03%) ⬆️
unit-windows 51.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added this to the 1.5.6 milestone Nov 23, 2023
@mmetc mmetc merged commit 7ffa0cc into master Nov 23, 2023
14 checks passed
@mmetc mmetc deleted the docker-local-item-bind branch November 23, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants