Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: avoid nil dereference #2773

Merged
merged 1 commit into from
Jan 23, 2024
Merged

appsec: avoid nil dereference #2773

merged 1 commit into from
Jan 23, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 22, 2024

No description provided.

@mmetc mmetc added this to the 1.5.6 milestone Jan 22, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (84606eb) 47.76% compared to head (3693d57) 56.86%.

Files Patch % Lines
pkg/appsec/request.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2773      +/-   ##
==========================================
+ Coverage   47.76%   56.86%   +9.09%     
==========================================
  Files         141      237      +96     
  Lines       17842    30641   +12799     
==========================================
+ Hits         8523    17424    +8901     
- Misses       8393    11530    +3137     
- Partials      926     1687     +761     
Flag Coverage Δ
bats 36.66% <0.00%> (?)
unit-linux 52.23% <0.00%> (?)
unit-windows 47.75% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 4b8e6cd into master Jan 23, 2024
17 checks passed
@mmetc mmetc deleted the appsec-nil branch January 23, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants