Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify systemd start, stop, reload, watchdog #2862

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 26, 2024

This removes the debug line "systemd not available" but I verified that the function is called and it's a no-op outside systemd.

TODO: WATCHDOG_USEC, signal READY after reload

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.6.2 milestone Feb 26, 2024
@mmetc mmetc added the kind/enhancement New feature or request label Feb 26, 2024
@mmetc mmetc requested a review from blotus February 26, 2024 14:48
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 57.99%. Comparing base (8e9e091) to head (7097891).

Files Patch % Lines
cmd/crowdsec/serve.go 68.57% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2862   +/-   ##
=======================================
  Coverage   57.98%   57.99%           
=======================================
  Files         240      240           
  Lines       31040    31059   +19     
=======================================
+ Hits        18000    18014   +14     
- Misses      11411    11415    +4     
- Partials     1629     1630    +1     
Flag Coverage Δ
bats 38.01% <68.57%> (+0.02%) ⬆️
unit-linux 52.27% <ø> (+0.01%) ⬆️
unit-windows 47.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the systemd-notify branch 2 times, most recently from 2c9b689 to 8ea358c Compare February 26, 2024 15:29
@mmetc mmetc changed the title notify systemd start, stop, reload notify systemd start, stop, reload, watchdog Feb 26, 2024
@mmetc mmetc marked this pull request as ready for review February 26, 2024 15:36
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 57.99%. Comparing base (2a7e838) to head (7097891).
Report is 36 commits behind head on master.

❗ Current head 7097891 differs from pull request most recent head bcbfb9f. Consider uploading reports for the commit bcbfb9f to get more accurate results

Files Patch % Lines
cmd/crowdsec/serve.go 68.57% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2862      +/-   ##
==========================================
- Coverage   58.10%   57.99%   -0.11%     
==========================================
  Files         243      240       -3     
  Lines       31361    31059     -302     
==========================================
- Hits        18221    18014     -207     
+ Misses      11460    11415      -45     
+ Partials     1680     1630      -50     
Flag Coverage Δ
bats 38.01% <68.57%> (-0.18%) ⬇️
unit-linux 52.27% <ø> (+0.15%) ⬆️
unit-windows 47.78% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as draft April 23, 2024 08:28
@mmetc mmetc modified the milestones: 1.6.2, 1.6.3 Apr 30, 2024
@mmetc mmetc removed this from the 1.6.3 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants