Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deb, rpm: handle api key creation (skip or ignore error) in case of .yaml.local and remote LAPI #275

Merged
merged 9 commits into from
May 10, 2023
Merged

deb, rpm: handle api key creation (skip or ignore error) in case of .yaml.local and remote LAPI #275

merged 9 commits into from
May 10, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 9, 2023 •
edited
Loading

fix for #274

@mmetc mmetc changed the title handle postinst with pre-existing api-key in .yaml.local postinst: skip api key creation if already defined in .yaml.local May 9, 2023
@mmetc mmetc marked this pull request as ready for review May 10, 2023 07:08
sabban
sabban approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc changed the title postinst: skip api key creation if already defined in .yaml.local deb, rpm: handle api key creation (skip or ignore error) in case of .yaml.local and remote LAPI May 10, 2023
sabban
sabban approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 3c7c5ff into main May 10, 2023
@mmetc mmetc deleted the local-api-key branch May 10, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabban sabban sabban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmetc @sabban