Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0: Refactor config #8

Merged
merged 3 commits into from
Apr 13, 2023
Merged

1.0.0: Refactor config #8

merged 3 commits into from
Apr 13, 2023

Conversation

crowemi
Copy link
Owner

@crowemi crowemi commented Apr 5, 2023

Major updates to configuration to allow for future expansion of formats and cloud providers.

@crowemi crowemi requested a review from pnadolny13 April 5, 2023 23:05
@crowemi crowemi changed the title Refactor config 1.0.0: Refactor config Apr 5, 2023
@pnadolny13
Copy link
Collaborator

@crowemi this is cool, I'm planning to do a review of the code and clone and test it out myself locally but initially I had a question: what is your vision for this target? I see you mentioned this being multi cloud in the future, does that mean this would not longer be an S3 target but more of a generic cloud object storage target?

@pnadolny13
Copy link
Collaborator

I think this was discussed in an SDK (or Meltano) issue about pulling some of this cloud provider logic in, a challenge that came up was the fact that unneeded dependencies will always be install. If this target supports all major cloud providers but I only need AWS then I'm still constantly installing all dependencies needed for GCP/Azure/etc. even though they arent used. I wonder if using extras would be a good approach. Not a big deal but something to consider.

@crowemi
Copy link
Owner Author

crowemi commented Apr 6, 2023

@pnadolny13, thank you for reviewing!

what is your vision for this target?

My use-case is (and likely always will be) for S3. But, in this Singer Most Wanted we had talked about creating a cloud agnostic target.

I see you mentioned this being multi cloud in the future, does that mean this would not longer be an S3 target but more of a generic cloud object storage target?

Yes, I was thinking this target could become target-data-lake and serve as a multi-cloud storage/multi-format target.


I like the idea of extras, that will def be on my radar.

@pnadolny13
Copy link
Collaborator

My use-case is (and likely always will be) for S3. But, in this MeltanoLabs/Singer-Most-Wanted#70 we had talked about creating a cloud agnostic target.

@crowemi ah ok I didnt see that thread, sound good!

@crowemi crowemi merged commit 73783a1 into main Apr 13, 2023
@crowemi crowemi deleted the refactor-config branch April 13, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants