Extend login mechanism #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches (almost) the entire login process to use beta api endpoints. Login via session id is sometimes not possible in the
masterbranch, only god knows the reason for this. This is one part which is fixed by this PR.Internally, the
etp_rtcookie is now used instead of asession_idwhen login. This is much more reliable than the session id. This cookie is generated when logged in tocrunchyroll.comand using the curnchyroll beta.With this, a new
LoginWithEtpRt(...)method is added which allows to login directly via theetp_rtcookie.LoginWithSessionID(...)is deprecated because of its unreliability and will be removed later until session id login is removed completely or login with it does not work for a longer period of time.The
session_idfield inCrunchyrollwas replaced byetp_rttoo.The cli
logincommand also stores theetp_rtcookie instead of session id in a temporary file now.